netdev - Re: [PATCH v4 04/11] net: dsa: microchip: ksz8795: use port

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <07467628-bd2d-46e3-ca3f-74c2687110b9@gmail.com>
Date:   Mon, 3 Aug 2020 10:40:02 -0700
From:   Florian Fainelli <f.fainelli@...il.com>
To:     Michael Grzeschik <m.grzeschik@...gutronix.de>, andrew@...n.ch
Cc:     netdev@...r.kernel.org, davem@...emloft.net, kernel@...gutronix.de
Subject: Re: [PATCH v4 04/11] net: dsa: microchip: ksz8795: use port_cnt where
 possible



On 8/2/2020 10:44 PM, Michael Grzeschik wrote:
> Since the driver can be used on more switches it needs
> to use flexible port count whereever possible.
> 
> Signed-off-by: Michael Grzeschik <m.grzeschik@...gutronix.de>

Since you appear to have access to a dsa_switch instance in most cases,
maybe consider using ds->num_ports directly? Not necessarily a big deal
and the current change is an improvement anyway.

Reviewed-by: Florian Fainelli <f.fainelli@...il.com>
-- 
Florian