lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Sun, 2 Aug 2020 18:16:58 -0700 From: Andrii Nakryiko <andrii.nakryiko@...il.com> To: Tianjia Zhang <tianjia.zhang@...ux.alibaba.com> Cc: Alexei Starovoitov <ast@...nel.org>, Daniel Borkmann <daniel@...earbox.net>, Martin Lau <kafai@...com>, Song Liu <songliubraving@...com>, Yonghong Song <yhs@...com>, Andrii Nakryiko <andriin@...com>, john fastabend <john.fastabend@...il.com>, KP Singh <kpsingh@...omium.org>, Quentin Monnet <quentin@...valent.com>, Jakub Kicinski <kuba@...nel.org>, Toke Høiland-Jørgensen <toke@...hat.com>, Tobias Klauser <tklauser@...tanz.ch>, Jiri Olsa <jolsa@...nel.org>, Networking <netdev@...r.kernel.org>, bpf <bpf@...r.kernel.org>, open list <linux-kernel@...r.kernel.org>, tianjia.zhang@...baba.com Subject: Re: [PATCH] tools/bpf/bpftool: Fix wrong return value in do_dump() On Sun, Aug 2, 2020 at 4:16 AM Tianjia Zhang <tianjia.zhang@...ux.alibaba.com> wrote: > > In case of btf_id does not exist, a negative error code -ENOENT > should be returned. > > Fixes: c93cc69004df3 ("bpftool: add ability to dump BTF types") > Cc: Andrii Nakryiko <andriin@...com> > Signed-off-by: Tianjia Zhang <tianjia.zhang@...ux.alibaba.com> > --- Acked-by: Andrii Nakryiko <andriin@...com> > tools/bpf/bpftool/btf.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/tools/bpf/bpftool/btf.c b/tools/bpf/bpftool/btf.c > index faac8189b285..c2f1fd414820 100644 > --- a/tools/bpf/bpftool/btf.c > +++ b/tools/bpf/bpftool/btf.c > @@ -596,7 +596,7 @@ static int do_dump(int argc, char **argv) > goto done; > } > if (!btf) { > - err = ENOENT; > + err = -ENOENT; > p_err("can't find btf with ID (%u)", btf_id); > goto done; > } > -- > 2.26.2 >
Powered by blists - more mailing lists