netdev - Re: [PATCH v2 0/4 net-next] Improve MDIO Ethernet PHY reset

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20200803.150143.1814094529162821629.davem@davemloft.net>
Date:   Mon, 03 Aug 2020 15:01:43 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     bruno.thomsen@...il.com
Cc:     netdev@...r.kernel.org, andrew@...n.ch, festevam@...il.com,
        f.fainelli@...il.com, linux@...linux.org.uk, hkallweit1@...il.com,
        laa@...strup.com, bth@...strup.com
Subject: Re: [PATCH v2 0/4 net-next] Improve MDIO Ethernet PHY reset

From: Bruno Thomsen <bruno.thomsen@...il.com>
Date: Thu, 30 Jul 2020 21:57:45 +0200

> This patch series is a result of trying to upstream a new device
> tree for a TQMa7D based board[1][2]. Initial this DTS used some
> deprecated PHY reset properties on the FEC device; NXP Ethernet
> MAC also known as Freescale Fast Ethernet Controller.
> 
> When switching from FEC properties[3]:
> "phy-reset-gpios"
> "phy-reset-duration"
> "phy-reset-post-delay"
> 
> To MDIO PHY properties[4]:
> "reset-gpios"
> "reset-assert-us"
> "reset-deassert-us"
> 
> The result was that no Ethernet PHY device was detected on boot.
> 
> This issue could be worked around by disabling PHY type ID auto-
> detection by using "ethernet-phy-id0022.1560" as compatible
> string and not "ethernet-phy-ieee802.3-c22".
> 
> Upstreaming a DTS with this workaround was not accepted, so I
> digged into the MDIO reset flow and found that it had a few
> missing parts compared to the deprecated FEC reset function.
> After some more testing and logic analyzer traces it was
> revealed that the failed PHY communication was due to missing
> initial device reset.
 ...

Series applied, thank you.