netdev - Re: [PATCH net] net: gre: recompute gre csum for sctp over gre tunnels

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20200803.153024.29144597725572653.davem@davemloft.net>
Date:   Mon, 03 Aug 2020 15:30:24 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     lorenzo@...nel.org
Cc:     netdev@...r.kernel.org, lorenzo.bianconi@...hat.com,
        tom@...bertland.com
Subject: Re: [PATCH net] net: gre: recompute gre csum for sctp over gre
 tunnels

From: Lorenzo Bianconi <lorenzo@...nel.org>
Date: Fri, 31 Jul 2020 20:12:05 +0200

> The GRE tunnel can be used to transport traffic that does not rely on a
> Internet checksum (e.g. SCTP). The issue can be triggered creating a GRE
> or GRETAP tunnel and transmitting SCTP traffic ontop of it where CRC
> offload has been disabled. In order to fix the issue we need to
> recompute the GRE csum in gre_gso_segment() not relying on the inner
> checksum.
> The issue is still present when we have the CRC offload enabled.
> In this case we need to disable the CRC offload if we require GRE
> checksum since otherwise skb_checksum() will report a wrong value.
> 
> Fixes: 4749c09c37030 ("gre: Call gso_make_checksum")
> Signed-off-by: Lorenzo Bianconi <lorenzo@...nel.org>

Applied with Fixes: tag corrected and queued up for -stable.

Thanks.