netdev - Re: [PATCH net-next] cxgb4: fix extracting IP addresses in TC-FLOWER rules

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20200803.153421.1214139307689007135.davem@davemloft.net>
Date:   Mon, 03 Aug 2020 15:34:21 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     rahul.lakkireddy@...lsio.com
Cc:     netdev@...r.kernel.org, vishal@...lsio.com, dt@...lsio.com
Subject: Re: [PATCH net-next] cxgb4: fix extracting IP addresses in
 TC-FLOWER rules

From: Rahul Lakkireddy <rahul.lakkireddy@...lsio.com>
Date: Sat,  1 Aug 2020 02:23:40 +0530

> commit c8729cac2a11 ("cxgb4: add ethtool n-tuple filter insertion")
> has removed checking control key for determining IP address types
> for TC-FLOWER rules, which causes all the rules being inserted to
> hardware to become IPv6 rule type always. So, add back the check
> to select the correct IP address type to extract and hence fix the
> correct rule type being inserted to hardware.
> 
> Also, ethtool_rx_flow_key doesn't have any control key and instead
> directly sets the IPv4/IPv6 address keys. So, explicitly set the
> IP address type for ethtool n-tuple filters to reuse the same code.
> 
> Fixes: c8729cac2a11 ("cxgb4: add ethtool n-tuple filter insertion")
> Signed-off-by: Rahul Lakkireddy <rahul.lakkireddy@...lsio.com>

Applied.