netdev - Re: [PATCH] net: Use __skb_pagelen() directly in skb_cow

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20200803.153855.1717799017490441577.davem@davemloft.net>
Date:   Mon, 03 Aug 2020 15:38:55 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     linmiaohe@...wei.com
Cc:     kuba@...nel.org, fw@...len.de, pshelar@....org,
        martin.varghese@...ia.com, pabeni@...hat.com, edumazet@...gle.com,
        dcaratti@...hat.com, steffen.klassert@...unet.com,
        shmulik@...anetworks.com, kyk.segfault@...il.com,
        netdev@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] net: Use __skb_pagelen() directly in skb_cow_data()

From: linmiaohe <linmiaohe@...wei.com>
Date: Sat, 1 Aug 2020 17:30:23 +0800

> From: Miaohe Lin <linmiaohe@...wei.com>
> 
> In fact, skb_pagelen() - skb_headlen() is equal to __skb_pagelen(), use it
> directly to avoid unnecessary skb_headlen() call.
> 
> Also fix the CHECK note of checkpatch.pl:
>     Comparison to NULL could be written "!__pskb_pull_tail"
> 
> Signed-off-by: Miaohe Lin <linmiaohe@...wei.com>

Applied.