netdev - Re: [PATCH] atm: eni: avoid accessing the data mapped to streaming DMA

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20200803.155138.467790375085778952.davem@davemloft.net>
Date:   Mon, 03 Aug 2020 15:51:38 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     baijiaju@...nghua.edu.cn
Cc:     3chas3@...il.com, linux-atm-general@...ts.sourceforge.net,
        netdev@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] atm: eni: avoid accessing the data mapped to streaming
 DMA

From: Jia-Ju Bai <baijiaju@...nghua.edu.cn>
Date: Sun,  2 Aug 2020 17:16:11 +0800

> In do_tx(), skb->data is mapped to streaming DMA on line 1111:
>   paddr = dma_map_single(...,skb->data,DMA_TO_DEVICE);
> 
> Then skb->data is accessed on line 1153:
>   (skb->data[3] & 0xf)
> 
> This access may cause data inconsistency between CPU cache and hardware.
> 
> To fix this problem, skb->data[3] is assigned to a local variable before
> DMA mapping, and then the driver accesses this local variable instead of
> skb->data[3].
> 
> Signed-off-by: Jia-Ju Bai <baijiaju@...nghua.edu.cn>

Applied.