netdev - Re: [PATCH] qmi_wwan: support modify usbnet's rx_urb

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <202008031745.i7nguP22%lkp@intel.com>
Date:   Mon, 3 Aug 2020 18:01:46 +0800
From:   kernel test robot <lkp@...el.com>
To:     yzc666@...ease.com, bjorn@...k.no
Cc:     kbuild-all@...ts.01.org, davem@...emloft.net, kuba@...nel.org,
        netdev@...r.kernel.org, linux-usb@...r.kernel.org,
        carl <carl.yin@...ctel.com>
Subject: Re: [PATCH]     qmi_wwan: support modify usbnet's rx_urb_size

Hi,

I love your patch! Yet something to improve:

[auto build test ERROR on sparc-next/master]
[also build test ERROR on linus/master v5.8 next-20200731]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/yzc666-netease-com/qmi_wwan-support-modify-usbnet-s-rx_urb_size/20200803-152459
base:   https://git.kernel.org/pub/scm/linux/kernel/git/davem/sparc-next.git master
config: sh-allmodconfig (attached as .config)
compiler: sh4-linux-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=sh 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@...el.com>

All errors (new ones prefixed by >>):

>> drivers/net/usb/qmi_wwan.c:546:3: error: 'dev_attr_rx_urb_size' undeclared here (not in a function)
     546 |  &dev_attr_rx_urb_size.attr,
         |   ^~~~~~~~~~~~~~~~~~~~
   drivers/net/usb/qmi_wwan.c:410:16: warning: 'rx_urb_size_store' defined but not used [-Wunused-function]
     410 | static ssize_t rx_urb_size_store(struct device *d,  struct device_attribute *attr,
         |                ^~~~~~~~~~~~~~~~~
   drivers/net/usb/qmi_wwan.c:403:16: warning: 'rx_urb_size_show' defined but not used [-Wunused-function]
     403 | static ssize_t rx_urb_size_show(struct device *d, struct device_attribute *attr, char *buf)
         |                ^~~~~~~~~~~~~~~~

vim +/dev_attr_rx_urb_size +546 drivers/net/usb/qmi_wwan.c

   544	
   545	static struct attribute *qmi_wwan_sysfs_attrs[] = {
 > 546		&dev_attr_rx_urb_size.attr,
   547		&dev_attr_raw_ip.attr,
   548		&dev_attr_add_mux.attr,
   549		&dev_attr_del_mux.attr,
   550		NULL,
   551	};
   552	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

Download attachment ".config.gz" of type "application/gzip" (55659 bytes)