lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:   Mon, 3 Aug 2020 13:22:03 +0200
From:   Jiri Pirko <jiri@...nulli.us>
To:     Vasundhara Volam <vasundhara-v.volam@...adcom.com>
Cc:     netdev@...r.kernel.org, dsahern@...il.com,
        stephen@...workplumber.org, davem@...emloft.net, jiri@...lanox.com,
        kuba@...nel.org, michael.chan@...adcom.com
Subject: Re: [PATCH v3 iproute2-next] devlink: Add board.serial_number to
 info subcommand.

Fri, Jul 31, 2020 at 12:46:43PM CEST, vasundhara-v.volam@...adcom.com wrote:
>Add support for reading board serial_number to devlink info
>subcommand. Example:
>
>$ devlink dev info pci/0000:af:00.0 -jp
>{
>    "info": {
>        "pci/0000:af:00.0": {
>            "driver": "bnxt_en",
>            "serial_number": "00-10-18-FF-FE-AD-1A-00",
>            "board.serial_number": "433551F+172300000",
>            "versions": {
>                "fixed": {
>                    "board.id": "7339763 Rev 0.",
>                    "asic.id": "16D7",
>                    "asic.rev": "1"
>                },
>                "running": {
>                    "fw": "216.1.216.0",
>                    "fw.psid": "0.0.0",
>                    "fw.mgmt": "216.1.192.0",
>                    "fw.mgmt.api": "1.10.1",
>                    "fw.ncsi": "0.0.0.0",
>                    "fw.roce": "216.1.16.0"
>                }
>            }
>        }
>    }
>}
>
>Signed-off-by: Vasundhara Volam <vasundhara-v.volam@...adcom.com>

Looks fine.

Reviewed-by: Jiri Pirko <jiri@...lanox.com>

Powered by blists - more mailing lists