netdev - Re: [PATCH ethtool 2/7] cable_test: clean up unused parameters

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20200803235927.GO1862409@lunn.ch>
Date:   Tue, 4 Aug 2020 01:59:27 +0200
From:   Andrew Lunn <andrew@...n.ch>
To:     Michal Kubecek <mkubecek@...e.cz>
Cc:     netdev@...r.kernel.org
Subject: Re: [PATCH ethtool 2/7] cable_test: clean up unused parameters

On Mon, Aug 03, 2020 at 01:57:09PM +0200, Michal Kubecek wrote:
> Functions nl_cable_test_ntf_attr() and nl_cable_test_tdr_ntf_attr() do not
> use nlctx parameter and as they are not callbacks with fixed signature, we
> can simply drop it. Once we do, the same is true for cable_test_ntf_nest()
> and cable_test_tdr_ntf_nest().
> 
> Signed-off-by: Michal Kubecek <mkubecek@...e.cz>

Reviewed-by: Andrew Lunn <andrew@...n.ch>

    Andrew