netdev - RE: [RFC PATCH v4 bpf-next 02/12] tcp: bpf: Add TCP_BPF_DELACK

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5f28b29440d41_62272b02d7c945b48e@john-XPS-13-9370.notmuch>
Date:   Mon, 03 Aug 2020 17:57:56 -0700
From:   John Fastabend <john.fastabend@...il.com>
To:     Martin KaFai Lau <kafai@...com>, bpf@...r.kernel.org
Cc:     Alexei Starovoitov <ast@...nel.org>,
        Daniel Borkmann <daniel@...earbox.net>,
        Eric Dumazet <edumazet@...gle.com>, kernel-team@...com,
        Lawrence Brakmo <brakmo@...com>,
        Neal Cardwell <ncardwell@...gle.com>, netdev@...r.kernel.org,
        Yuchung Cheng <ycheng@...gle.com>
Subject: RE: [RFC PATCH v4 bpf-next 02/12] tcp: bpf: Add TCP_BPF_DELACK_MAX
 setsockopt

Martin KaFai Lau wrote:
> This change is mostly from an internal patch and adapts it from sysctl
> config to the bpf_setsockopt setup.
> 
> The bpf_prog can set the max delay ack by using
> bpf_setsockopt(TCP_BPF_DELACK_MAX).  This max delay ack can be communicated
> to its peer through bpf header option.  The receiving peer can then use
> this max delay ack and set a potentially lower rto by using
> bpf_setsockopt(TCP_BPF_RTO_MIN) which will be introduced
> in the next patch.
> 
> Another later selftest patch will also use it like the above to show
> how to write and parse bpf tcp header option.
> 
> Reviewed-by: Eric Dumazet <edumazet@...gle.com>
> Signed-off-by: Martin KaFai Lau <kafai@...com>
> ---

Acked-by: John Fastabend <john.fastabend@...il.com>