netdev - Re: [PATCH ethtool] ethtool.spec: Add bash completion script

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20200804131216.gn6qgwvniulsqjzd@lion.mk-sys.cz>
Date:   Tue, 4 Aug 2020 15:12:16 +0200
From:   Michal Kubecek <mkubecek@...e.cz>
To:     Roi Dayan <roid@...lanox.com>
Cc:     netdev@...r.kernel.org
Subject: Re: [PATCH ethtool] ethtool.spec: Add bash completion script

On Mon, Aug 03, 2020 at 04:23:38PM +0300, Roi Dayan wrote:
> After the additon of the bash completion script, packaging
> using the default spec file fails for installed but not packaged
> error. so package it.
> 
> Fixes: 9b802643d7bd ("ethtool: Add bash-completion script")
> Signed-off-by: Roi Dayan <roid@...lanox.com>

Applied, thank you. We are using a heavily modified specfile in openSUSE
so I never noticed. Added rpmbuild to my check script now.

Michal

> ---
>  ethtool.spec.in | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/ethtool.spec.in b/ethtool.spec.in
> index 9c01b07abf2b..75f9be6aafa6 100644
> --- a/ethtool.spec.in
> +++ b/ethtool.spec.in
> @@ -34,6 +34,7 @@ make install DESTDIR=${RPM_BUILD_ROOT}
>  %defattr(-,root,root)
>  %{_sbindir}/ethtool
>  %{_mandir}/man8/ethtool.8*
> +%{_datadir}/bash-completion/completions/ethtool
>  %doc AUTHORS COPYING NEWS README
>  
>  
> -- 
> 2.8.4
> 

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)