lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  PHC 
Open Source and information security mailing list archives
Hash Suite for Android: free password hash cracker in your pocket
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Date:   Tue, 4 Aug 2020 07:34:07 -0700
From:   Eric Dumazet <>
To:     linmiaohe <>
Cc:     David Miller <>,
        Jakub Kicinski <>,
        Pravin B Shelar <>,
        Florian Westphal <>,,
        Willem de Bruijn <>,
        Davide Caratti <>,
        Steffen Klassert <>,
        Paolo Abeni <>,,, netdev <>,
        LKML <>
Subject: Re: [PATCH] net: Fix potential out of bound write in skb_try_coalesce()

On Tue, Aug 4, 2020 at 4:46 AM linmiaohe <> wrote:
> From: Miaohe Lin <>
> The head_frag of skb would occupy one extra skb_frag_t. Take it into
> account or out of bound write to skb frags may happen.
> Signed-off-by: Miaohe Lin <>

Please share a stack trace if this was a real bug spotted in the wild.

I do not believe this patch is correct.

if (A + B >= MAX)   is equivalent to  if (A + B + 1 > MAX)

Note how the other condition (when there is no bytes in skb header) is coded :

if (A + B > MAX) return false;

In anycase, please always provide a Fixes: tag for any bug fix.


Powered by blists - more mailing lists