netdev - Re: [PATCH V2] via-velocity: Use more typical logging styles

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20200804.125507.1365180086597649192.davem@davemloft.net>
Date:   Tue, 04 Aug 2020 12:55:07 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     joe@...ches.com
Cc:     romieu@...zoreil.com, kuba@...nel.org, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH V2] via-velocity: Use more typical logging styles

From: Joe Perches <joe@...ches.com>
Date: Mon, 03 Aug 2020 20:23:13 -0700

> Use netdev_<level> in place of VELOCITY_PRT.
> Use pr_<level> in place of printk(KERN_<LEVEL>.
> 
> Miscellanea:
> 
> o Add pr_fmt to prefix pr_<level> output with "via-velocity: "
> o Remove now unused functions and macros
> o Realign some logging lines
> o Remove devname where pr_<level> is also used
> 
> Signed-off-by: Joe Perches <joe@...ches.com>

Yeah I definitely like this better, applied, thanks.