netdev - Re: PROBLEM: (DSA/Microchip): 802.1Q-Header lost on KSZ9477-DSA ingress without bridge

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 4 Aug 2020 13:20:25 -0700
From:   Florian Fainelli <f.fainelli@...il.com>
To:     Vladimir Oltean <olteanv@...il.com>
Cc:     "Gaube, Marvin (THSE-TL1)" <Marvin.Gaube@...at.de>,
        Woojung Huh <woojung.huh@...rochip.com>,
        Microchip Linux Driver Support <UNGLinuxDriver@...rochip.com>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>
Subject: Re: PROBLEM: (DSA/Microchip): 802.1Q-Header lost on KSZ9477-DSA
 ingress without bridge



On 8/4/2020 12:54 PM, Vladimir Oltean wrote:
> On Tue, Aug 04, 2020 at 08:51:00AM -0700, Florian Fainelli wrote:
>> "I looked into it deeper, the driver does rxvlan offloading."
>>
>> Is this part of the driver upstream or are you using a vendor tree from
>> Freescale which has that change included?
>>
> 
> Does it matter?

If this was a downstream problem yes, there would not necessarily be a
pressing need to address it with a patch targeting 'net' for instance.
This is not the case, therefore it should be addressed.

> FWIW, mainline fec does declare NETIF_F_HW_VLAN_CTAG_RX:
> https://elixir.bootlin.com/linux/latest/source/drivers/net/ethernet/freescale/fec_main.c#L3317
> and move it to the hwaccel area on RX:
> https://elixir.bootlin.com/linux/latest/source/drivers/net/ethernet/freescale/fec_main.c#L1513
> 

-- 
Florian