netdev - RE: [PATCH][v2] i40e: optimise prefetch page refcount

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <BN6PR1101MB2145FBEC323CA803DD7F1DF78C4A0@BN6PR1101MB2145.namprd11.prod.outlook.com>
Date:   Tue, 4 Aug 2020 20:58:42 +0000
From:   "Bowers, AndrewX" <andrewx.bowers@...el.com>
To:     "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "intel-wired-lan@...ts.osuosl.org" <intel-wired-lan@...ts.osuosl.org>
Subject: RE: [PATCH][v2] i40e: optimise prefetch page refcount

> -----Original Message-----
> From: Li RongQing <lirongqing@...du.com>
> Sent: Friday, July 31, 2020 3:38 AM
> To: netdev@...r.kernel.org; intel-wired-lan@...ts.osuosl.org;
> kuba@...nel.org; Bowers, AndrewX <andrewx.bowers@...el.com>;
> Nguyen, Anthony L <anthony.l.nguyen@...el.com>
> Subject: [PATCH][v2] i40e: optimise prefetch page refcount
> 
> refcount of rx_buffer page will be added here originally, so prefetchw is
> needed, but after commit 1793668c3b8c ("i40e/i40evf: Update code to
> better handle incrementing page count"), and refcount is not added
> everytime, so change prefetchw as prefetch,
> 
> now it mainly services page_address(), but which accesses struct page only
> when WANT_PAGE_VIRTUAL or HASHED_PAGE_VIRTUAL is defined
> otherwise it returns address based on offset, so we prefetch it conditionally
> 
> Jakub suggested to define prefetch_page_address in a common header
> 
> Suggested-by: Jakub Kicinski <kuba@...nel.org>
> Signed-off-by: Li RongQing <lirongqing@...du.com>
> ---
> diff with v1: create a common function prefetch_page_address
> 
>  drivers/net/ethernet/intel/i40e/i40e_txrx.c | 2 +-
>  include/linux/prefetch.h                    | 7 +++++++
>  2 files changed, 8 insertions(+), 1 deletion(-)

Tested-by: Andrew Bowers <andrewx.bowers@...el.com>