netdev - Re: [PATCH] net: macb: Properly handle phylink on at91sam9x

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Tue, 04 Aug 2020 16:05:03 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     sr@...x.de
Cc:     netdev@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
        reto.schneider@...qvarnagroup.com, alexandre.belloni@...tlin.com,
        nicolas.ferre@...rochip.com
Subject: Re: [PATCH] net: macb: Properly handle phylink on at91sam9x

From: Stefan Roese <sr@...x.de>
Date: Tue,  4 Aug 2020 14:17:16 +0200

> I just recently noticed that ethernet does not work anymore since v5.5
> on the GARDENA smart Gateway, which is based on the AT91SAM9G25.
> Debugging showed that the "GEM bits" in the NCFGR register are now
> unconditionally accessed, which is incorrect for the !macb_is_gem()
> case.
> 
> This patch adds the macb_is_gem() checks back to the code
> (in macb_mac_config() & macb_mac_link_up()), so that the GEM register
> bits are not accessed in this case any more.
> 
> Fixes: 7897b071ac3b ("net: macb: convert to phylink")
> Signed-off-by: Stefan Roese <sr@...x.de>

Applied and queued up for -stable, thanks.