netdev - Re: [RFC PATCH v4 bpf-next 04/12] tcp: Add saw_unknown to struct tcp_options

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CANn89iLWG=r1mpZB4W2LtyBSo0Ee1pkkt2-GBC5Ru_F3ugzw-w@mail.gmail.com>
Date:   Mon, 3 Aug 2020 17:21:24 -0700
From:   Eric Dumazet <edumazet@...gle.com>
To:     Martin KaFai Lau <kafai@...com>
Cc:     bpf <bpf@...r.kernel.org>, Alexei Starovoitov <ast@...nel.org>,
        Daniel Borkmann <daniel@...earbox.net>,
        kernel-team <kernel-team@...com>,
        Lawrence Brakmo <brakmo@...com>,
        Neal Cardwell <ncardwell@...gle.com>,
        netdev <netdev@...r.kernel.org>,
        Yuchung Cheng <ycheng@...gle.com>
Subject: Re: [RFC PATCH v4 bpf-next 04/12] tcp: Add saw_unknown to struct tcp_options_received

On Mon, Aug 3, 2020 at 4:10 PM Martin KaFai Lau <kafai@...com> wrote:
>
> In a later patch, the bpf prog only wants to be called to handle
> a header option if that particular header option cannot be handled by
> the kernel.  This unknown option could be written by the peer's bpf-prog.
> It could also be a new standard option that the running kernel does not
> support it while a bpf-prog can handle it.
>
> This patch adds a "saw_unknown" bit to "struct tcp_options_received"
> and it uses an existing one byte hole to do that.  "saw_unknown" will
> be set in tcp_parse_options() if it sees an option that the kernel
> cannot handle.
>
> Signed-off-by: Martin KaFai Lau <kafai@...com>
> ---

Reviewed-by: Eric Dumazet <edumazet@...gle.com>