netdev - Re: [EXT] Re: [PATCH v5 net-next 04/10] qed: implement devlink info request

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <79e9a8ca-3c6b-8ded-8a6a-1f4455e4e752@marvell.com>
Date:   Tue, 4 Aug 2020 10:21:20 +0300
From:   Igor Russkikh <irusskikh@...vell.com>
To:     Jakub Kicinski <kuba@...nel.org>
CC:     <netdev@...r.kernel.org>, "David S . Miller" <davem@...emloft.net>,
        "Ariel Elior" <aelior@...vell.com>,
        Michal Kalderon <mkalderon@...vell.com>,
        "Denis Bolotin" <dbolotin@...vell.com>,
        Jiri Pirko <jiri@...nulli.us>,
        "Alexander Lobakin" <alobakin@...vell.com>
Subject: Re: [EXT] Re: [PATCH v5 net-next 04/10] qed: implement devlink info
 request


Hi Jakub,

On 04/08/2020 12:29 am, Jakub Kicinski wrote:

>> ~$ sudo ~/iproute2/devlink/devlink  dev info
>> pci/0000:01:00.0:
>>   driver qed
>>   serial_number REE1915E44552
> 
> Just to confirm - this is not:
> 
>    * - ``board.serial_number``
>      - Board serial number of the device.
> 
>        This is usually the serial number of the board, often available in
>        PCI *Vital Product Data*.

I'm not sure on difference between board. or just serial_number, but lspci
shows this ID as a part of vital product data.

Considering this you are right, its better to change to "board.serial_number".

>> Running FW (or fastpath FW) is an embedded microprogram implementing
>> all the packet processing, offloads, etc. This FW is being loaded
>> on each start by the driver from FW binary blob.
> 
> Sounds like you should use:
> 
> fw.app - Data path microcode controlling high-speed packet processing.

Thanks, agreed.

Jakub, David, I'll prepare v6. Should I postpone posting v6 until the next
cycle then?

Regards,
  Igor