netdev - Re: [PATCH] ethtool: Add QSFP-DD support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAL_jBfSMe5YDxsKgdX8yD+2yjdQ7LCm3BVi22F+NZ7L1dJm+Ww@mail.gmail.com>
Date:   Tue, 4 Aug 2020 09:23:28 +0100
From:   Adrian Pop <popadrian1996@...il.com>
To:     Ido Schimmel <idosch@...sch.org>
Cc:     netdev@...r.kernel.org, linville@...driver.com,
        davem@...emloft.net, kuba@...nel.org, jiri@...lanox.com,
        vadimp@...lanox.com, mlxsw@...lanox.com,
        Ido Schimmel <idosch@...lanox.com>,
        Andrew Lunn <andrew@...n.ch>
Subject: Re: [PATCH] ethtool: Add QSFP-DD support

Hi Andrew, Ido!

> Hi Adrian, thanks again for submitting this patch. I got two comments
> off-list. Sharing them here.

Thanks for pointing that out, I took a look and you're right. I'll fix them.

> Didn't we discuss that page 3 might be useful? I would prefer not to
> document that pages 0x10 and 0x11 would follow page 2 until we have a
> driver which does actually provide pages 0x10 and 0x11.

Should I just remove that bit about 0x10 and 0x11 from the commit
message (so keep only the first two paragraphs) and leave the code as
it is?

Adrian