netdev - RE: [PATCH v2] ravb: Fixed the problem that rmmod can not be done

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <OSAPR01MB384402DF70DE090C10BAB4F8DF480@OSAPR01MB3844.jpnprd01.prod.outlook.com>
Date:   Thu, 6 Aug 2020 02:28:36 +0000
From:   "ashiduka@...itsu.com" <ashiduka@...itsu.com>
To:     'Sergei Shtylyov' <sergei.shtylyov@...il.com>
CC:     "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "linux-renesas-soc@...r.kernel.org" 
        <linux-renesas-soc@...r.kernel.org>,
        "David S. Miller" <davem@...emloft.net>
Subject: RE: [PATCH v2] ravb: Fixed the problem that rmmod can not be done

Hi Sergei,

>    CCing DaveM (as you should have done from the start)...

Thank you. I appreciate your help.

>    Did you also build mdio-bitbang.c as a module?

Yes. Sure.

> For the in-kernal driver, not being able to rmmod the 'ravb' one sounds
> logical. :-)

root@...r-gen3:~# lsmod|grep ravb
ravb                   40960  1
mdio_bitbang           16384  1 ravb
root@...r-gen3:~# modprobe -r ravb
modprobe: FATAL: Module ravb is in use.
root@...r-gen3:~# modprobe -r mdio_bitbang
modprobe: FATAL: Module mdio_bitbang is in use.

>> Fixed to execute mdio_init() at open and free_mdio() at close, thereby rmmod is
>    Call ravb_mdio_init() at open and free_mdio_bitbang() at close.

OK. 
Include the exact function name in the commit log, not the abbreviated function name.

>   Dave, would you tolerate the forward declarations here instead (to avoid the function moves, to be later
> done in the net-next tree)?

Wait for Dave's reply for a while.
(If Dave's reply is slow, I will only correct Sergei's issue and post it)

Thanks & Best Regards,
Yuusuke Ashizuka <ashiduka@...itsu.com>