lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Thu, 6 Aug 2020 08:27:07 +0530 From: "Rakesh Pillai" <pillair@...eaurora.org> To: "'Christophe JAILLET'" <christophe.jaillet@...adoo.fr>, <kvalo@...eaurora.org>, <davem@...emloft.net>, <kuba@...nel.org> Cc: <ath10k@...ts.infradead.org>, <linux-wireless@...r.kernel.org>, <netdev@...r.kernel.org>, <linux-kernel@...r.kernel.org>, <kernel-janitors@...r.kernel.org> Subject: RE: [PATCH] ath10k: Fix the size used in a 'dma_free_coherent()' call in an error handling path > -----Original Message----- > From: Christophe JAILLET <christophe.jaillet@...adoo.fr> > Sent: Sunday, August 2, 2020 5:52 PM > To: kvalo@...eaurora.org; davem@...emloft.net; kuba@...nel.org; > pillair@...eaurora.org > Cc: ath10k@...ts.infradead.org; linux-wireless@...r.kernel.org; > netdev@...r.kernel.org; linux-kernel@...r.kernel.org; kernel- > janitors@...r.kernel.org; Christophe JAILLET > <christophe.jaillet@...adoo.fr> > Subject: [PATCH] ath10k: Fix the size used in a 'dma_free_coherent()' call in > an error handling path > > Update the size used in 'dma_free_coherent()' in order to match the one > used in the corresponding 'dma_alloc_coherent()'. > > Fixes: 1863008369ae ("ath10k: fix shadow register implementation for > WCN3990") > Signed-off-by: Christophe JAILLET <christophe.jaillet@...adoo.fr> > --- > This patch looks obvious to me, but commit 1863008369ae looks also simple. > So it is surprising that such a "typo" slipped in. Reviewed-by: Rakesh Pillai <pillair@...eaurora.org> > --- > drivers/net/wireless/ath/ath10k/ce.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/net/wireless/ath/ath10k/ce.c > b/drivers/net/wireless/ath/ath10k/ce.c > index 294fbc1e89ab..e6e0284e4783 100644 > --- a/drivers/net/wireless/ath/ath10k/ce.c > +++ b/drivers/net/wireless/ath/ath10k/ce.c > @@ -1555,7 +1555,7 @@ ath10k_ce_alloc_src_ring(struct ath10k *ar, > unsigned int ce_id, > ret = ath10k_ce_alloc_shadow_base(ar, src_ring, nentries); > if (ret) { > dma_free_coherent(ar->dev, > - (nentries * sizeof(struct > ce_desc_64) + > + (nentries * sizeof(struct ce_desc) + > CE_DESC_RING_ALIGN), > src_ring- > >base_addr_owner_space_unaligned, > base_addr); > -- > 2.25.1
Powered by blists - more mailing lists