lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  PHC 
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [thread-next>] [day] [month] [year] [list]
Date:   Thu, 6 Aug 2020 17:27:11 +0100
From:   Colin Ian King <>
To:     Vladimir Oltean <>, Andrew Lunn <>,
        Vivien Didelot <>,
        Florian Fainelli <>,
        "David S. Miller" <>,
        Jakub Kicinski <>
Cc:     "" <>,
        "" <>
Subject: re: net: dsa: sja1105: use detected device id instead of DT one on


Static analysis with Coverity has detected a potential issue with the
following commit:

commit 0b0e299720bb99428892a23ecbd2b4b7f61ccf6d
Author: Vladimir Oltean <>
Date:   Mon Aug 3 19:48:23 2020 +0300

    net: dsa: sja1105: use detected device id instead of DT one on mismatch

The analysis is as follows:

Array compared against 0 (NO_EFFECT)array_null: Comparing an array to
null is not useful: match->compatible, since the test will always
evaluate as true.

    Was match->compatible formerly declared as a pointer?

3418        for (match = sja1105_dt_ids; match->compatible; match++) {
3419                const struct sja1105_info *info = match->data;

I'm not sure what the original intention was, so I was unable to fix
this hence I'm sending this report as I think it needs addressing.


Powered by blists - more mailing lists