netdev - Re: [PATCH] drivers/net/wan/lapbether: Added needed

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAJht_ENbEh1JFhk57YD+MteOafv6+PgE25hRUjyiPk9B48dEVA@mail.gmail.com>
Date:   Thu, 6 Aug 2020 04:21:53 -0700
From:   Xie He <xie.he.0141@...il.com>
To:     Willem de Bruijn <willemdebruijn.kernel@...il.com>
Cc:     "David S. Miller" <davem@...emloft.net>,
        Jakub Kicinski <kuba@...nel.org>,
        Network Development <netdev@...r.kernel.org>,
        linux-kernel <linux-kernel@...r.kernel.org>,
        Linux X25 <linux-x25@...r.kernel.org>,
        Martin Schiller <ms@....tdt.de>,
        Brian Norris <briannorris@...omium.org>
Subject: Re: [PATCH] drivers/net/wan/lapbether: Added needed_headroom and a
 skb->len check

On Thu, Aug 6, 2020 at 12:47 AM Willem de Bruijn
<willemdebruijn.kernel@...il.com> wrote:
>
> Acked-by: Willem de Bruijn <willemb@...gle.com>
>
> The in-band signal byte is required, but stripped by lapbeth_xmit.
> Subsequent code will prefix additional headers, including an Ethernet
> link layer. The extra space needs to be reserved, but not pulled in
> packet_snd with skb_reserve, so has to use needed_headroom instead of
> hard_header_len.

Thank you, Willem!