netdev - Re: [PATCH bpf] selftests/bpf: fix silent Makefile output

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <717ce941-5f80-dcfa-6c75-1fd230bc67a2@iogearbox.net>
Date:   Fri, 7 Aug 2020 19:02:49 +0200
From:   Daniel Borkmann <daniel@...earbox.net>
To:     Andrii Nakryiko <andriin@...com>, bpf@...r.kernel.org,
        netdev@...r.kernel.org, ast@...com
Cc:     andrii.nakryiko@...il.com, kernel-team@...com
Subject: Re: [PATCH bpf] selftests/bpf: fix silent Makefile output

On 8/7/20 5:30 AM, Andrii Nakryiko wrote:
> 99aacebecb75 ("selftests: do not use .ONESHELL") removed .ONESHELL, which
> changes how Makefile "silences" multi-command target recipes. selftests/bpf's
> Makefile relied (a somewhat unknowingly) on .ONESHELL behavior of silencing
> all commands within the recipe if the first command contains @ symbol.
> Removing .ONESHELL exposed this hack.
> 
> This patch fixes the issue by explicitly silencing each command with $(Q).
> 
> Also explicitly define fallback rule for building *.o from *.c, instead of
> relying on non-silent inherited rule. This was causing a non-silent output for
> bench.o object file.
> 
> Fixes: 92f7440ecc93 ("selftests/bpf: More succinct Makefile output")
> Signed-off-by: Andrii Nakryiko <andriin@...com>

Looks good, applied thanks!