lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Fri, 7 Aug 2020 17:06:41 +0900 From: Yoshiki Komachi <komachi.yoshiki@...il.com> To: David Ahern <dsahern@...il.com> Cc: "David S. Miller" <davem@...emloft.net>, Alexei Starovoitov <ast@...nel.org>, Daniel Borkmann <daniel@...earbox.net>, Jesper Dangaard Brouer <hawk@...nel.org>, John Fastabend <john.fastabend@...il.com>, Jakub Kicinski <kuba@...nel.org>, Martin KaFai Lau <kafai@...com>, Song Liu <songliubraving@...com>, Yonghong Song <yhs@...com>, Andrii Nakryiko <andriin@...com>, KP Singh <kpsingh@...omium.org>, Roopa Prabhu <roopa@...ulusnetworks.com>, Nikolay Aleksandrov <nikolay@...ulusnetworks.com>, David Ahern <dsahern@...nel.org>, netdev@...r.kernel.org, bridge@...ts.linux-foundation.org, bpf@...r.kernel.org Subject: Re: [RFC PATCH bpf-next 2/3] bpf: Add helper to do forwarding lookups in kernel FDB table > 2020/08/06 1:38、David Ahern <dsahern@...il.com>のメール: > > On 8/4/20 5:27 AM, Yoshiki Komachi wrote: >> >> I guess that no build errors will occur because the API is allowed when >> CONFIG_BRIDGE is enabled. >> >> I successfully build my kernel applying this patch, and I don’t receive any >> messages from build robots for now. > > If CONFIG_BRIDGE is a module, build should fail: filter.c is built-in > trying to access a symbol from module. When I tried building my kernel with CONFIG_BRIDGE set as a module, I got the following error as you pointed out: ld: net/core/filter.o: in function `____bpf_xdp_fdb_lookup': /root/bpf-next/net/core/filter.c:5108: undefined reference to `br_fdb_find_port_xdp' It may be necessary to fix it to support kernels built with CONFIG_BRIDGE set as a mfodule, so let me make sure if it should be called via netdev ops to get destination port in a bridge again. Thanks & Best regards, — Yoshiki Komachi komachi.yoshiki@...il.com
Powered by blists - more mailing lists