netdev - Re: [PATCH v2 2/3] drivers: crypto: add support for OCTEONTX2 CPT engine

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200807082437.246a9f1c@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
Date:   Fri, 7 Aug 2020 08:24:37 -0700
From:   Jakub Kicinski <kuba@...nel.org>
To:     Srujana Challa <schalla@...vell.com>
Cc:     <herbert@...dor.apana.org.au>, <davem@...emloft.net>,
        <netdev@...r.kernel.org>, <linux-crypto@...r.kernel.org>,
        <schandran@...vell.com>, <pathreya@...vell.com>,
        <sgoutham@...vell.com>, <lcherian@...vell.com>,
        <gakula@...vell.com>, <jerinj@...vell.com>
Subject: Re: [PATCH v2 2/3] drivers: crypto: add support for OCTEONTX2 CPT
 engine

On Fri, 7 Aug 2020 19:39:19 +0530 Srujana Challa wrote:
> Add support for the cryptographic acceleration unit (CPT) on
> OcteonTX2 CN96XX SoC.

Please address the W=1 C=1 build warnings

../drivers/crypto/marvell/octeontx2/otx2_cptpf_main.c:475:51: warning: cast removes address space '__iomem' of expression
../drivers/crypto/marvell/octeontx2/otx2_cptpf_mbox.c:158:39: warning: incorrect type in assignment (different address spaces)
../drivers/crypto/marvell/octeontx2/otx2_cptpf_mbox.c:158:39:    expected void *lmtline
../drivers/crypto/marvell/octeontx2/otx2_cptpf_mbox.c:158:39:    got void [noderef] __iomem *
../drivers/crypto/marvell/octeontx2/otx2_cptpf_mbox.c:161:37: warning: incorrect type in assignment (different address spaces)
../drivers/crypto/marvell/octeontx2/otx2_cptpf_mbox.c:161:37:    expected void *ioreg
../drivers/crypto/marvell/octeontx2/otx2_cptpf_mbox.c:161:37:    got void [noderef] __iomem *
../drivers/crypto/marvell/octeontx2/otx2_cptpf_ucode.c:394:22: warning: cast to restricted __be32
../drivers/crypto/marvell/octeontx2/otx2_cptpf_ucode.c:394:22: warning: cast to restricted __be32
../drivers/crypto/marvell/octeontx2/otx2_cptpf_ucode.c:394:22: warning: cast to restricted __be32
../drivers/crypto/marvell/octeontx2/otx2_cptpf_ucode.c:394:22: warning: cast to restricted __be32
../drivers/crypto/marvell/octeontx2/otx2_cptpf_ucode.c:394:22: warning: cast to restricted __be32
../drivers/crypto/marvell/octeontx2/otx2_cptpf_ucode.c:394:22: warning: cast to restricted __be32
../drivers/crypto/marvell/octeontx2/otx2_cptpf_ucode.c:1025:23: warning: cast to restricted __be32
../drivers/crypto/marvell/octeontx2/otx2_cptpf_ucode.c:1025:23: warning: cast to restricted __be32
../drivers/crypto/marvell/octeontx2/otx2_cptpf_ucode.c:1025:23: warning: cast to restricted __be32
../drivers/crypto/marvell/octeontx2/otx2_cptpf_ucode.c:1025:23: warning: cast to restricted __be32
../drivers/crypto/marvell/octeontx2/otx2_cptpf_ucode.c:1025:23: warning: cast to restricted __be32
../drivers/crypto/marvell/octeontx2/otx2_cptpf_ucode.c:1025:23: warning: cast to restricted __be32
../drivers/crypto/marvell/octeontx2/otx2_cptpf_ucode.c:1887:29: warning: incorrect type in assignment (different base types)
../drivers/crypto/marvell/octeontx2/otx2_cptpf_ucode.c:1887:29:    expected unsigned short [assigned] [usertype] opcode
../drivers/crypto/marvell/octeontx2/otx2_cptpf_ucode.c:1887:29:    got restricted __be16 [usertype]