netdev - Re: [PATCH net] mptcp: more stable diag self-tests

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Fri, 07 Aug 2020 17:25:58 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     pabeni@...hat.com
Cc:     netdev@...r.kernel.org, kuba@...nel.org, mptcp@...ts.01.org
Subject: Re: [PATCH net] mptcp: more stable diag self-tests

From: Paolo Abeni <pabeni@...hat.com>
Date: Fri,  7 Aug 2020 18:31:00 +0200

> During diag self-tests we introduce long wait in the mptcp test
> program to give the script enough time to access the sockets
> dump.
> 
> Such wait is introduced after shutting down one sockets end. Since
> commit 43b54c6ee382 ("mptcp: Use full MPTCP-level disconnect state
> machine") if both sides shutdown the socket is correctly transitioned
> into CLOSED status.
> 
> As a side effect some sockets are not dumped via the diag interface,
> because the socket state (CLOSED) does not match the default filter, and
> this cause self-tests instability.
> 
> Address the issue moving the above mentioned wait before shutting
> down the socket.
> 
> Closes: https://github.com/multipath-tcp/mptcp_net-next/issues/68
> Fixes: df62f2ec3df6 ("selftests/mptcp: add diag interface tests")
> Tested-and-acked-by: Matthieu Baerts <matthieu.baerts@...sares.net>
> Signed-off-by: Paolo Abeni <pabeni@...hat.com>

Applied, thanks.