netdev - Re: [PATCH] net: eliminate meaningless memcpy to data in pskb_carve_inside

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Date:   Tue, 11 Aug 2020 11:54:28 +0000
From:   linmiaohe <linmiaohe@...wei.com>
To:     Florian Westphal <fw@...len.de>
CC:     "davem@...emloft.net" <davem@...emloft.net>,
        "kuba@...nel.org" <kuba@...nel.org>,
        "pshelar@....org" <pshelar@....org>,
        "martin.varghese@...ia.com" <martin.varghese@...ia.com>,
        "dcaratti@...hat.com" <dcaratti@...hat.com>,
        "edumazet@...gle.com" <edumazet@...gle.com>,
        "steffen.klassert@...unet.com" <steffen.klassert@...unet.com>,
        "pabeni@...hat.com" <pabeni@...hat.com>,
        "shmulik@...anetworks.com" <shmulik@...anetworks.com>,
        "kyk.segfault@...il.com" <kyk.segfault@...il.com>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] net: eliminate meaningless memcpy to data in
 pskb_carve_inside_nonlinear()

Florian Westphal <fw@...len.de> wrote:
>Miaohe Lin <linmiaohe@...wei.com> wrote:
>> The skb_shared_info part of the data is assigned in the following loop.
>
>Where?
>

It's at the below for (i = 0; i < nfrags; i++) loop. But I missed something as Eric Dumazet pointed out.
Sorry about it.