lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  PHC 
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:   Tue, 11 Aug 2020 09:01:20 -0700
From:   Jakub Kicinski <>
Cc:     Boris Pismenny <>,
        Aviad Yehezkel <>,
        John Fastabend <>,
        Daniel Borkmann <>,
        "David S. Miller" <>,
        Ilya Lesokhin <>,,
Subject: Re: [PATCH] net/tls: Fix kmap usage

On Mon, 10 Aug 2020 17:02:58 -0700 wrote:
> From: Ira Weiny <>
> When MSG_OOB is specified to tls_device_sendpage() the mapped page is
> never unmapped.

Nice catch!

> Hold off mapping the page until after the flags are checked and the page
> is actually needed.

We could take the kmap/kunmap from under the socket lock, but that'd
perhaps be more code reshuffling than we need in a fix.

Fixes: e8f69799810c ("net/tls: Add generic NIC offload infrastructure")
Reviewed-by: Jakub Kicinski <>

Powered by blists - more mailing lists