netdev - Re: [PATCH] net: openvswitch: introduce common code for flushing flows

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20200811.102339.667052777479413338.davem@davemloft.net>
Date:   Tue, 11 Aug 2020 10:23:39 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     xiangxia.m.yue@...il.com
Cc:     joel@...lfernandes.org, jknoos@...gle.com, gvrose8192@...il.com,
        urezki@...il.com, paulmck@...nel.org, dev@...nvswitch.org,
        netdev@...r.kernel.org, rcu@...r.kernel.org
Subject: Re: [PATCH] net: openvswitch: introduce common code for flushing
 flows

From: xiangxia.m.yue@...il.com
Date: Tue, 11 Aug 2020 09:10:01 +0800

> diff --git a/net/openvswitch/datapath.c b/net/openvswitch/datapath.c
> index 42f8cc70bb2c..5fec47e62615 100644
> --- a/net/openvswitch/datapath.c
> +++ b/net/openvswitch/datapath.c
> @@ -1756,6 +1756,9 @@ static int ovs_dp_cmd_new(struct sk_buff *skb, struct genl_info *info)
>  /* Called with ovs_mutex. */
>  static void __dp_destroy(struct datapath *dp)
>  {
> +	struct flow_table *table = &dp->table;
> +	struct table_instance *ufid_ti = ovsl_dereference(table->ufid_ti);
> +	struct table_instance *ti = ovsl_dereference(table->ti);
>  	int i;
>  
>  	for (i = 0; i < DP_VPORT_HASH_BUCKETS; i++) {

Please use reverse christmas tree ordering for local variables.