netdev - Re: [PATCH net] Revert "vxlan: fix tos value before xmit"

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20200811.170223.1397578654908672695.davem@davemloft.net>
Date:   Tue, 11 Aug 2020 17:02:23 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     liuhangbin@...il.com
Cc:     gnault@...hat.com, netdev@...r.kernel.org, pmachata@...il.com,
        roopa@...ulusnetworks.com, dsahern@...nel.org, akaris@...hat.com
Subject: Re: [PATCH net] Revert "vxlan: fix tos value before xmit"

From: Hangbin Liu <liuhangbin@...il.com>
Date: Thu, 6 Aug 2020 10:52:41 +0800

> The rough steps are setting vxlan tunnel on OVS. set inner packet tos to
> 1011 1010 (0xba) and outer vxlan to 1111 1100(0xfc). The outer packet's tos
> should be 0xfe at latest as it inherit the inner ECN bit. But with RT_TOS(tos)
> We actually got tos 0x1e as the first 3 bits are omitted.
> 
> Now here is detailed testing steps:

This explains why we need to revert the RT_TOS() change.

I'm asking what testing you did on the original change that added
RT_TOS(), which we reverted, and which didn't fix anything.

I want to know how we got into this situation in the first place,
adding a change that only added negative effects.

Thank you.