netdev - Re: [PATCH RFC russell-king 2/4] net: phy: sfp: add support for multigig RollBall modules

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200812153326.71b84e45@dellmb.labs.office.nic.cz>
Date:   Wed, 12 Aug 2020 15:33:26 +0200
From:   Marek Behún <marek.behun@....cz>
To:     Russell King - ARM Linux admin <linux@...linux.org.uk>
Cc:     Andrew Lunn <andrew@...n.ch>,
        Maxime Chevallier <maxime.chevallier@...tlin.com>,
        Baruch Siach <baruch@...s.co.il>,
        Chris Healy <cphealy@...il.com>,
        Florian Fainelli <f.fainelli@...il.com>, netdev@...r.kernel.org
Subject: Re: [PATCH RFC russell-king 2/4] net: phy: sfp: add support for
 multigig RollBall modules

On Tue, 11 Aug 2020 16:15:53 +0100
Russell King - ARM Linux admin <linux@...linux.org.uk> wrote:

> > +	if (rollball) {
> > +		/* TODO: try to write this to EEPROM */
> > +		id.base.extended_cc = SFF8024_ECC_10GBASE_T_SFI;  
> 
> Should we really be "fixing" vendors EEPROMs for them?
> 

Are you reffering to the TODO comment or the id.base.extended_cc
assignment?
If the comment, well, your code does it for cotsworks modules, but I am
actually indifferent.
If the assignment - either this needs to be done or the
sfp_probe_for_phy and sfp_may_have_phy functions have to be changed so
that they check for rollball module by vendor ID.

Marek