netdev - Re: [PATCH bpf] tools/bpftool: make skeleton code C++17-friendly by dropping typeof()

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <510B2A6E-60EA-459D-A40D-9C21182C166A@fb.com>
Date:   Wed, 12 Aug 2020 15:34:37 +0000
From:   Song Liu <songliubraving@...com>
To:     Andrii Nakryiko <andriin@...com>
CC:     bpf <bpf@...r.kernel.org>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        Alexei Starovoitov <ast@...com>,
        "daniel@...earbox.net" <daniel@...earbox.net>,
        "andrii.nakryiko@...il.com" <andrii.nakryiko@...il.com>,
        Kernel Team <Kernel-team@...com>
Subject: Re: [PATCH bpf] tools/bpftool: make skeleton code C++17-friendly by
 dropping typeof()



> On Aug 11, 2020, at 7:59 PM, Andrii Nakryiko <andriin@...com> wrote:
> 
> Seems like C++17 standard mode doesn't recognize typeof() anymore. This can
> be tested by compiling test_cpp test with -std=c++17 or -std=c++1z options.
> The use of typeof in skeleton generated code is unnecessary, all types are
> well-known at the time of code generation, so remove all typeof()'s to make
> skeleton code more future-proof when interacting with C++ compilers.
> 
> Fixes: 985ead416df3 ("bpftool: Add skeleton codegen command")
> Signed-off-by: Andrii Nakryiko <andriin@...com>

Acked-by: Song Liu <songliubraving@...com>

Cc: <stable@...r.kernel.org> # v5.7+