netdev - Re: [PATCH] i40e: fix uninitialized variable in i40e_set_vsi

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 12 Aug 2020 10:46:28 -0700
From:   Jakub Kicinski <kuba@...nel.org>
To:     Stefan Assmann <sassmann@...nic.de>
Cc:     intel-wired-lan@...ts.osuosl.org, netdev@...r.kernel.org,
        davem@...emloft.net, jeffrey.t.kirsher@...el.com,
        lihong.yang@...el.com
Subject: Re: [PATCH] i40e: fix uninitialized variable in
 i40e_set_vsi_promisc

On Wed, 12 Aug 2020 16:39:50 +0200 Stefan Assmann wrote:
> drivers/net/ethernet/intel/i40e/i40e_virtchnl_pf.c: In function ‘i40e_set_vsi_promisc’:
> drivers/net/ethernet/intel/i40e/i40e_virtchnl_pf.c:1176:14: error: ‘aq_ret’ may be used uninitialized in this function [-Werror=maybe-uninitialized]
>   i40e_status aq_ret;

What's your compiler? I don't see it on GCC 10.1.

> In case the code inside the if statement and the for loop does not get
> executed aq_ret will be uninitialized when the variable gets returned at
> the end of the function.

I think it'd be a better fix to make num_vlans unsigned.