netdev - Re: [PATCH v2 2/3] drivers: crypto: add support for OCTEONTX2 CPT engine

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 13 Aug 2020 10:54:07 +1000
From:   Herbert Xu <herbert@...dor.apana.org.au>
To:     Srujana Challa <schalla@...vell.com>
Cc:     davem@...emloft.net, netdev@...r.kernel.org,
        linux-crypto@...r.kernel.org, schandran@...vell.com,
        pathreya@...vell.com, sgoutham@...vell.com, lcherian@...vell.com,
        gakula@...vell.com, jerinj@...vell.com
Subject: Re: [PATCH v2 2/3] drivers: crypto: add support for OCTEONTX2 CPT
 engine

On Fri, Aug 07, 2020 at 07:39:19PM +0530, Srujana Challa wrote:
>
> +#if defined(CONFIG_ARM64)
> +static inline long otx2_lmt_flush(void *ioreg)
> +{
> +	long result = 0;
> +
> +	__asm__ volatile(".cpu  generic+lse\n"
> +			 "ldeor xzr, %0, [%1]\n"
> +			 : "=r" (result)
> +			 : "r" (ioreg) : "memory");
> +
> +	return result;
> +}
> +
> +#else
> +#define otx2_lmt_flush(addr)     ({ 0; })
> +#endif

This is not acceptable.  Please work out a way with the ARM folks
to fix this without adding assembly code in a driver.

Thanks,
-- 
Email: Herbert Xu <herbert@...dor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt