netdev - Re: [PATCH] tools build feature: Quote CC and CXX for their arguments

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20200813130127.GO13995@kernel.org>
Date:   Thu, 13 Aug 2020 10:01:27 -0300
From:   Arnaldo Carvalho de Melo <acme@...nel.org>
To:     Tom Hebb <tommyhebb@...il.com>
Cc:     Daniel Díaz <daniel.diaz@...aro.org>,
        Alexei Starovoitov <ast@...nel.org>,
        Daniel Borkmann <daniel@...earbox.net>,
        Martin KaFai Lau <kafai@...com>,
        Song Liu <songliubraving@...com>, Yonghong Song <yhs@...com>,
        Andrii Nakryiko <andriin@...com>,
        John Fastabend <john.fastabend@...il.com>,
        KP Singh <kpsingh@...omium.org>,
        Arnaldo Carvalho de Melo <acme@...hat.com>,
        Jiri Olsa <jolsa@...nel.org>,
        Stephane Eranian <eranian@...gle.com>,
        Namhyung Kim <namhyung@...nel.org>,
        open list <linux-kernel@...r.kernel.org>,
        "open list:BPF (Safe dynamic programs and tools)" 
        <netdev@...r.kernel.org>,
        "open list:BPF (Safe dynamic programs and tools)" 
        <bpf@...r.kernel.org>
Subject: Re: [PATCH] tools build feature: Quote CC and CXX for their arguments

Em Wed, Aug 12, 2020 at 07:31:32PM -0700, Tom Hebb escreveu:
> On Wed, Aug 12, 2020 at 3:15 PM Daniel Díaz <daniel.diaz@...aro.org> wrote:
> >   Makefile.config:414: *** No gnu/libc-version.h found, please install glibc-dev[el].  Stop.
> >   Makefile.perf:230: recipe for target 'sub-make' failed
> >   make[1]: *** [sub-make] Error 2
> >   Makefile:69: recipe for target 'all' failed
> >   make: *** [all] Error 2
> >
> > With CC and CXX quoted, some of those features are now detected.
> >
> > Fixes: e3232c2f39ac ("tools build feature: Use CC and CXX from parent")
> >
> > Signed-off-by: Daniel Díaz <daniel.diaz@...aro.org>
> 
> Whoops, I'm the one who introduced this issue. Fix looks good, thanks!
> 
> Reviewed-by: Thomas Hebb <tommyhebb@...il.com>
> Fixes: e3232c2f39ac ("tools build feature: Use CC and CXX from parent")

Thanks, applied.

- Arnaldo