lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Date:   Fri, 14 Aug 2020 10:11:43 -0700
From:   Andrii Nakryiko <andrii.nakryiko@...il.com>
To:     Miaohe Lin <linmiaohe@...wei.com>
Cc:     Alexei Starovoitov <ast@...nel.org>,
        Daniel Borkmann <daniel@...earbox.net>,
        Martin Lau <kafai@...com>, Song Liu <songliubraving@...com>,
        Yonghong Song <yhs@...com>, Andrii Nakryiko <andriin@...com>,
        john fastabend <john.fastabend@...il.com>,
        KP Singh <kpsingh@...omium.org>,
        "David S. Miller" <davem@...emloft.net>,
        Jakub Kicinski <kuba@...nel.org>,
        Jesper Dangaard Brouer <hawk@...nel.org>,
        Networking <netdev@...r.kernel.org>, bpf <bpf@...r.kernel.org>,
        open list <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] bpf: Convert to use the preferred fallthrough macro

On Fri, Aug 14, 2020 at 2:58 AM Miaohe Lin <linmiaohe@...wei.com> wrote:
>
> Convert the uses of fallthrough comments to fallthrough macro.
>
> Signed-off-by: Miaohe Lin <linmiaohe@...wei.com>
> ---
>  kernel/bpf/cgroup.c   | 2 +-
>  kernel/bpf/cpumap.c   | 2 +-
>  kernel/bpf/syscall.c  | 2 +-
>  kernel/bpf/verifier.c | 6 +++---
>  4 files changed, 6 insertions(+), 6 deletions(-)
>
> diff --git a/kernel/bpf/cgroup.c b/kernel/bpf/cgroup.c
> index 83ff127ef7ae..e21de4f1754c 100644
> --- a/kernel/bpf/cgroup.c
> +++ b/kernel/bpf/cgroup.c
> @@ -1794,7 +1794,7 @@ static bool cg_sockopt_is_valid_access(int off, int size,
>                         return prog->expected_attach_type ==
>                                 BPF_CGROUP_GETSOCKOPT;
>                 case offsetof(struct bpf_sockopt, optname):
> -                       /* fallthrough */
> +                       fallthrough;

this fallthrough is not event necessary, let's drop it instead?

>                 case offsetof(struct bpf_sockopt, level):
>                         if (size != size_default)
>                                 return false;

[...]

Powered by blists - more mailing lists