netdev - Re: [PATCH net v5] net: xdp: account for layer 3 packets in generic skb handler

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAHmME9pQwHeVAseqzA9WYMeh1VHZKRRUc1J=VzWv_0Zoyf8uPg@mail.gmail.com>
Date:   Fri, 14 Aug 2020 22:57:35 +0200
From:   "Jason A. Donenfeld" <Jason@...c4.com>
To:     David Miller <davem@...emloft.net>
Cc:     netdev@...r.kernel.org, bpf@...r.kernel.org, thomas@...kpuppet.org,
        adhipati@...a.io, dsahern@...il.com, toke@...hat.com,
        kuba@...nel.org, alexei.starovoitov@...il.com
Subject: Re: [PATCH net v5] net: xdp: account for layer 3 packets in generic
 skb handler

On 8/14/20, David Miller <davem@...emloft.net> wrote:
> From: "Jason A. Donenfeld" <Jason@...c4.com>
> Date: Fri, 14 Aug 2020 09:30:48 +0200
>
>> @@ -4676,6 +4688,7 @@ static u32 netif_receive_generic_xdp(struct sk_buff
>> *skb,
>>  	    (orig_bcast != is_multicast_ether_addr_64bits(eth->h_dest))) {
>>  		__skb_push(skb, ETH_HLEN);
>>  		skb->protocol = eth_type_trans(skb, skb->dev);
>> +		__skb_pull(skb, ETH_HLEN);
>>  	}
>>
>>  	switch (act) {
>
> This bug fix is separate from your other changes.  Please do not combine
> them.
>

No problem. I'll split this out and resend tomorrow morning.

Jason