lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Fri, 14 Aug 2020 12:39:10 +0100 From: Lee Jones <lee.jones@...aro.org> To: davem@...emloft.net, kuba@...nel.org Cc: linux-kernel@...r.kernel.org, Lee Jones <lee.jones@...aro.org>, Kalle Valo <kvalo@...eaurora.org>, Martin Langer <martin-langer@....de>, Stefano Brivio <stefano.brivio@...imi.it>, Michael Buesch <m@...s.ch>, van Dyk <kugelfang@...too.org>, Andreas Jaggi <andreas.jaggi@...erwave.ch>, Albert Herranz <albert_herranz@...oo.es>, linux-wireless@...r.kernel.org, b43-dev@...ts.infradead.org, netdev@...r.kernel.org Subject: [PATCH 07/30] net: wireless: broadcom: b43: main: Add braces around empty statements Fixes the following W=1 kernel build warning(s): drivers/net/wireless/broadcom/b43/main.c: In function ‘b43_dummy_transmission’: drivers/net/wireless/broadcom/b43/main.c:785:3: warning: suggest braces around empty body in an ‘if’ statement [-Wempty-body] drivers/net/wireless/broadcom/b43/main.c: In function ‘b43_do_interrupt_thread’: drivers/net/wireless/broadcom/b43/main.c:2017:3: warning: suggest braces around empty body in an ‘if’ statement [-Wempty-body] Cc: Kalle Valo <kvalo@...eaurora.org> Cc: "David S. Miller" <davem@...emloft.net> Cc: Jakub Kicinski <kuba@...nel.org> Cc: Martin Langer <martin-langer@....de> Cc: Stefano Brivio <stefano.brivio@...imi.it> Cc: Michael Buesch <m@...s.ch> Cc: van Dyk <kugelfang@...too.org> Cc: Andreas Jaggi <andreas.jaggi@...erwave.ch> Cc: Albert Herranz <albert_herranz@...oo.es> Cc: linux-wireless@...r.kernel.org Cc: b43-dev@...ts.infradead.org Cc: netdev@...r.kernel.org Signed-off-by: Lee Jones <lee.jones@...aro.org> --- drivers/net/wireless/broadcom/b43/main.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/net/wireless/broadcom/b43/main.c b/drivers/net/wireless/broadcom/b43/main.c index a54dd4f7fa54a..2a29fa69f692c 100644 --- a/drivers/net/wireless/broadcom/b43/main.c +++ b/drivers/net/wireless/broadcom/b43/main.c @@ -781,8 +781,9 @@ void b43_dummy_transmission(struct b43_wldev *dev, bool ofdm, bool pa_on) b43_write16(dev, B43_MMIO_XMTSEL, 0x0826); b43_write16(dev, B43_MMIO_TXE0_CTL, 0x0000); - if (!pa_on && phy->type == B43_PHYTYPE_N) + if (!pa_on && phy->type == B43_PHYTYPE_N) { ; /*b43_nphy_pa_override(dev, false) */ + } switch (phy->type) { case B43_PHYTYPE_N: @@ -2013,8 +2014,9 @@ static void b43_do_interrupt_thread(struct b43_wldev *dev) handle_irq_beacon(dev); if (reason & B43_IRQ_PMQ) handle_irq_pmq(dev); - if (reason & B43_IRQ_TXFIFO_FLUSH_OK) + if (reason & B43_IRQ_TXFIFO_FLUSH_OK) { ;/* TODO */ + } if (reason & B43_IRQ_NOISESAMPLE_OK) handle_irq_noise(dev); -- 2.25.1
Powered by blists - more mailing lists