lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:   Sun, 16 Aug 2020 11:05:49 -0700
From:   Eric Dumazet <eric.dumazet@...il.com>
To:     Hauke Mehrtens <hauke@...ke-m.de>, davem@...emloft.net
Cc:     kuba@...nel.org, netdev@...r.kernel.org,
        martin.blumenstingl@...glemail.com
Subject: Re: [PATCH 2/3] net: lantiq: use netif_tx_napi_add() for TX NAPI



On 8/15/20 11:33 AM, Hauke Mehrtens wrote:
> netif_tx_napi_add() should be used for NAPI in the TX direction instead
> of the netif_napi_add() function.
> 
> Fixes: fe1a56420cf2 ("net: lantiq: Add Lantiq / Intel VRX200 Ethernet driver")
> Signed-off-by: Hauke Mehrtens <hauke@...ke-m.de>
> ---
>  drivers/net/ethernet/lantiq_xrx200.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/net/ethernet/lantiq_xrx200.c b/drivers/net/ethernet/lantiq_xrx200.c
> index 1feb9fc710e0..f34e4dc8c661 100644
> --- a/drivers/net/ethernet/lantiq_xrx200.c
> +++ b/drivers/net/ethernet/lantiq_xrx200.c
> @@ -502,7 +502,7 @@ static int xrx200_probe(struct platform_device *pdev)
>  
>  	/* setup NAPI */
>  	netif_napi_add(net_dev, &priv->chan_rx.napi, xrx200_poll_rx, 32);
> -	netif_napi_add(net_dev, &priv->chan_tx.napi, xrx200_tx_housekeeping, 32);
> +	netif_tx_napi_add(net_dev, &priv->chan_tx.napi, xrx200_tx_housekeeping, 32);
>  
>  	platform_set_drvdata(pdev, priv);
>  
> 


This is not a must, simply a matter of (small) optimization in
the very rare case of busy polling users.

The Fixes: tag here is not necessary.

Powered by blists - more mailing lists