lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  PHC 
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:   Sun, 16 Aug 2020 11:15:41 -0700
From:   Eric Dumazet <>
To:     Pascal Bouchareine <>,
        "David S. Miller" <>,
        Jakub Kicinski <>,
        Andrew Morton <>,
        Alexey Dobriyan <>,
        Al Viro <>
Subject: Re: [PATCH 2/2] net: socket: implement SO_DESCRIPTION

On 8/15/20 11:23 AM, Pascal Bouchareine wrote:
> This command attaches the zero terminated string in optval to the
> socket for troubleshooting purposes. The free string is displayed in the
> process fdinfo file for that fd (/proc/<pid>/fdinfo/<fd>).
> One intended usage is to allow processes to self-document sockets
> for netstat and friends to report
> We ignore optlen and constrain the string to a static max size

1) You also ignored what would happen at accept() time.

Please test your patches with ASAN.

2) Also, why is that description specific to sockets ?

3) When a new socket option is added, it is customary to implement both setsockopt() and getsockopt()
  for things like CRIU.

Powered by blists - more mailing lists