netdev - Re: [PATCH net-next v2 3/5] net: xgene: Move shared header file into include/linux

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <6b10ced9-d5a6-85a6-c483-4ccd0691d05b@gmail.com>
Date:   Sun, 16 Aug 2020 13:59:53 -0700
From:   Florian Fainelli <f.fainelli@...il.com>
To:     Andrew Lunn <andrew@...n.ch>, David Miller <davem@...emloft.net>
Cc:     netdev <netdev@...r.kernel.org>,
        Heiner Kallweit <hkallweit1@...il.com>,
        Russell King <rmk+kernel@...linux.org.uk>
Subject: Re: [PATCH net-next v2 3/5] net: xgene: Move shared header file into
 include/linux



On 8/16/2020 11:56 AM, Andrew Lunn wrote:
> This header file is currently included into the ethernet driver via a
> relative path into the PHY subsystem. This is bad practice, and causes
> issues for the upcoming move of the MDIO driver. Move the header file
> into include/linux to clean this up.
> 
> Signed-off-by: Andrew Lunn <andrew@...n.ch>
> ---
>   drivers/net/ethernet/apm/xgene/xgene_enet_main.h | 2 +-
>   drivers/net/phy/mdio-xgene.c                     | 2 +-
>   {drivers/net/phy => include/linux}/mdio-xgene.h  | 0
>   3 files changed, 2 insertions(+), 2 deletions(-)
>   rename {drivers/net/phy => include/linux}/mdio-xgene.h (100%)

Depending on your response on patch #2, we could create 
include/linux/mdio/mdio-xgene.h, with that addressed or not:

Reviewed-by: Florian Fainelli <f.fainelli@...il.com>
-- 
Florian