netdev - Re: [PATCH ipsec] espintcp: restore IP CB before handing the packet to xfrm

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20200817140132.GQ13121@gauss3.secunet.de>
Date:   Mon, 17 Aug 2020 16:01:32 +0200
From:   Steffen Klassert <steffen.klassert@...unet.com>
To:     Sabrina Dubroca <sd@...asysnail.net>
CC:     <netdev@...r.kernel.org>, Xiumei Mu <xmu@...hat.com>
Subject: Re: [PATCH ipsec] espintcp: restore IP CB before handing the packet
 to xfrm

On Thu, Aug 13, 2020 at 04:24:04PM +0200, Sabrina Dubroca wrote:
> Xiumei reported a bug with espintcp over IPv6 in transport mode,
> because xfrm6_transport_finish expects to find IP6CB data (struct
> inet6_skb_cb). Currently, espintcp zeroes the CB, but the relevant
> part is actually preserved by previous layers (first set up by tcp,
> then strparser only zeroes a small part of tcp_skb_tb), so we can just
> relocate it to the start of skb->cb.
> 
> Fixes: e27cca96cd68 ("xfrm: add espintcp (RFC 8229)")
> Reported-by: Xiumei Mu <xmu@...hat.com>
> Signed-off-by: Sabrina Dubroca <sd@...asysnail.net>

Applied, thanks Sabrina!