lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Date:   Mon, 17 Aug 2020 14:58:45 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     min.li.xe@...esas.com
Cc:     richardcochran@...il.com, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH net] ptp: ptp_clockmatrix: use i2c_master_send for i2c
 write

From: <min.li.xe@...esas.com>
Date: Mon, 17 Aug 2020 11:37:35 -0400

> @@ -53,7 +53,9 @@
>  
>  #define OUTPUT_MODULE_FROM_INDEX(index)	(OUTPUT_0 + (index) * 0x10)
>  
> -#define PEROUT_ENABLE_OUTPUT_MASK		(0xdeadbeef)
> +#define PEROUT_ENABLE_OUTPUT_MASK	(0xdeadbeef)
> +
> +#define IDTCM_MAX_WRITE_COUNT		(512)

Why adjust the indentation of the value of PEROUT_ENABLE_OUTPUT_MASK?  It is meant
to line up with OUTPUT_MODULE_FROM_INDEX.

Please do not make unrelated changes like this and follow existing style and
indentation.

Thank you.

Powered by blists - more mailing lists