netdev - Re: [PATCH v3] net: qrtr: fix usage of idr in port assignment to socket

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20200817.150123.1361363231541199425.davem@davemloft.net>
Date:   Mon, 17 Aug 2020 15:01:23 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     fazilyildiran@...il.com
Cc:     kuba@...nel.org, bjorn.andersson@...aro.org,
        netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
        dvyukov@...gle.com, elver@...gle.com, andreyknvl@...gle.com,
        glider@...gle.com, necip@...gle.com,
        syzbot+f31428628ef672716ea8@...kaller.appspotmail.com
Subject: Re: [PATCH v3] net: qrtr: fix usage of idr in port assignment to
 socket

From: Necip Fazil Yildiran <fazilyildiran@...il.com>
Date: Mon, 17 Aug 2020 15:54:48 +0000

> From: Necip Fazil Yildiran <necip@...gle.com>
> 
> Passing large uint32 sockaddr_qrtr.port numbers for port allocation
> triggers a warning within idr_alloc() since the port number is cast
> to int, and thus interpreted as a negative number. This leads to
> the rejection of such valid port numbers in qrtr_port_assign() as
> idr_alloc() fails.
> 
> To avoid the problem, switch to idr_alloc_u32() instead.
> 
> Fixes: bdabad3e363d ("net: Add Qualcomm IPC router")
> Reported-by: syzbot+f31428628ef672716ea8@...kaller.appspotmail.com
> Signed-off-by: Necip Fazil Yildiran <necip@...gle.com>
> Reviewed-by: Dmitry Vyukov <dvyukov@...gle.com>

Applied and queued up for -stable, thank you.