lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Mon, 17 Aug 2020 10:26:16 +0200 From: Rasmus Villemoes <linux@...musvillemoes.dk> To: Christian Lamparter <chunkeey@...il.com>, Lee Jones <lee.jones@...aro.org>, davem@...emloft.net, kuba@...nel.org Cc: linux-kernel@...r.kernel.org, Christian Lamparter <chunkeey@...glemail.com>, Kalle Valo <kvalo@...eaurora.org>, Johannes Berg <johannes@...solutions.net>, linux-wireless@...r.kernel.org, netdev@...r.kernel.org Subject: Re: [PATCH 08/30] net: wireless: ath: carl9170: Mark 'ar9170_qmap' as __maybe_unused On 14/08/2020 17.14, Christian Lamparter wrote: > On 2020-08-14 13:39, Lee Jones wrote: >> 'ar9170_qmap' is used in some source files which include carl9170.h, >> but not all of them. Mark it as __maybe_unused to show that this is >> not only okay, it's expected. >> >> Fixes the following W=1 kernel build warning(s) > > Is this W=1 really a "must" requirement? I find it strange having > __maybe_unused in header files as this "suggests" that the > definition is redundant. In this case it seems one could replace the table lookup with a static inline u8 ar9170_qmap(u8 idx) { return 3 - idx; } gcc doesn't warn about unused static inline functions (or one would have a million warnings to deal with). Just my $0.02. Rasmus
Powered by blists - more mailing lists