netdev - Re: [PATCH net-next v3 3/3] smsc95xx: add phylib support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200818082510.380cd722@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
Date:   Tue, 18 Aug 2020 08:25:10 -0700
From:   Jakub Kicinski <kuba@...nel.org>
To:     Andre Edich <andre.edich@...rochip.com>
Cc:     <netdev@...r.kernel.org>, <UNGLinuxDriver@...rochip.com>,
        <steve.glendinning@...well.net>,
        <Parthiban.Veerasooran@...rochip.com>
Subject: Re: [PATCH net-next v3 3/3] smsc95xx: add phylib support

On Tue, 18 Aug 2020 13:11:27 +0200 Andre Edich wrote:
> +static inline int lan87xx_config_aneg(struct phy_device *phydev)

> +static inline int lan87xx_config_aneg_ext(struct phy_device *phydev)

Please don't use static inline in C files, the compiler will know what
to inline so it's unnecessary, and it hides dead code.