netdev - Re: [PATCH bpf] libbpf: fix build on ppc64le architecture

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAADnVQJggLTeT7r69C-CjzEO8S2WoJLhsJFSgAdYTrR37VvsNg@mail.gmail.com>
Date:   Tue, 18 Aug 2020 10:04:29 -0700
From:   Alexei Starovoitov <alexei.starovoitov@...il.com>
To:     Andrii Nakryiko <andriin@...com>
Cc:     bpf <bpf@...r.kernel.org>,
        Network Development <netdev@...r.kernel.org>,
        Alexei Starovoitov <ast@...com>,
        Daniel Borkmann <daniel@...earbox.net>,
        Andrii Nakryiko <andrii.nakryiko@...il.com>,
        Kernel Team <kernel-team@...com>
Subject: Re: [PATCH bpf] libbpf: fix build on ppc64le architecture

On Tue, Aug 18, 2020 at 9:47 AM Andrii Nakryiko <andriin@...com> wrote:
>
> On ppc64le we get the following warning:
>
>   In file included from btf_dump.c:16:0:
>   btf_dump.c: In function ‘btf_dump_emit_struct_def’:
>   ../include/linux/kernel.h:20:17: error: comparison of distinct pointer types lacks a cast [-Werror]
>     (void) (&_max1 == &_max2);  \
>                    ^
>   btf_dump.c:882:11: note: in expansion of macro ‘max’
>       m_sz = max(0LL, btf__resolve_size(d->btf, m->type));
>              ^~~
>
> Fix by explicitly casting to __s64, which is a return type from
> btf__resolve_size().
>
> Fixes: 702eddc77a90 ("libbpf: Handle GCC built-in types for Arm NEON")
> Signed-off-by: Andrii Nakryiko <andriin@...com>

Applied. Thanks