netdev - Re: [PATCH net-next 03/18] gve: Register netdev earlier

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200818200938.GK2330298@lunn.ch>
Date:   Tue, 18 Aug 2020 22:09:38 +0200
From:   Andrew Lunn <andrew@...n.ch>
To:     David Awogbemila <awogbemila@...gle.com>
Cc:     netdev@...r.kernel.org, Catherine Sullivan <csully@...gle.com>,
        Yangchun Fu <yangchun@...gle.com>
Subject: Re: [PATCH net-next 03/18] gve: Register netdev earlier

On Tue, Aug 18, 2020 at 12:44:02PM -0700, David Awogbemila wrote:
> From: Catherine Sullivan <csully@...gle.com>
> 
> Move the registration of the netdev up to initialize
> it before doing any logging so that the correct device name
> is displayed.

This is generally a bad idea. As soon as register_netdev() is called,
the device is in use. Packets are flowing. This is particularly true
with NFS root. The device must be 100% ready to do work before calling
register_netdev().

Take a look at dev_alloc_name().

     Andrew